Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested #2: Rename & move packages #1898

Merged
merged 17 commits into from
Jun 13, 2024
Merged

Nested #2: Rename & move packages #1898

merged 17 commits into from
Jun 13, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Jun 7, 2024 •
edited
Loading

  • Rename menu package into menuDrawer.
  • Move files related to the MoveFragment into a new move package.
  • Clean some random outdated code.
  • Rename item_folder_menu_drawer.xml into item_menu_drawer_folder.xml
  • Rename item_mailbox_menu_drawer.xml into item_menu_drawer_mailbox.xml

@KevinBoulongne KevinBoulongne added the optimization Improve the performance or efficiency of the code label Jun 7, 2024
@KevinBoulongne KevinBoulongne requested a review from a team June 7, 2024 07:15
@github-actions github-actions bot added the dependent This MR depends on another PR label Jun 7, 2024
@KevinBoulongne KevinBoulongne mentioned this pull request Jun 7, 2024
Closed
@KevinBoulongne KevinBoulongne changed the title Rename menu package into menuDrawer + Move some files to new move package Rename & move packages Jun 7, 2024
@KevinBoulongne KevinBoulongne added the quick A pull request consisting of a few lines label Jun 7, 2024
@KevinBoulongne KevinBoulongne marked this pull request as ready for review June 7, 2024 12:09
@KevinBoulongne KevinBoulongne enabled auto-merge June 7, 2024 12:22
@KevinBoulongne KevinBoulongne changed the title Rename & move packages Nested #2: Rename & move packages Jun 10, 2024
@KevinBoulongne KevinBoulongne force-pushed the nestedScrollViews-in-moveFragment branch from b74559b to 562d63c Compare June 11, 2024 06:19
@KevinBoulongne KevinBoulongne force-pushed the move-files branch 3 times, most recently from 437c2b6 to 62f4aff Compare June 11, 2024 09:04
@KevinBoulongne KevinBoulongne force-pushed the nestedScrollViews-in-moveFragment branch from d093545 to 0fef475 Compare June 12, 2024 08:17
@KevinBoulongne KevinBoulongne force-pushed the nestedScrollViews-in-moveFragment branch from 0fef475 to 0da6753 Compare June 13, 2024 08:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne changed the base branch from nestedScrollViews-in-moveFragment to nested-scroll-views June 13, 2024 10:40
@KevinBoulongne KevinBoulongne changed the title Nested #2: Rename & move packages Nested #1: Rename & move packages Jun 13, 2024
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jun 13, 2024
@KevinBoulongne KevinBoulongne merged commit 924eff7 into nested-scroll-views Jun 13, 2024
7 checks passed
@KevinBoulongne KevinBoulongne deleted the move-files branch June 13, 2024 10:40
@KevinBoulongne KevinBoulongne restored the move-files branch June 13, 2024 10:40
@KevinBoulongne KevinBoulongne changed the title Nested #1: Rename & move packages Nested #2: Rename & move packages Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
optimization Improve the performance or efficiency of the code quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @LunarX @tevincent